Why positional embeddings are implemented as just simple embeddings?

Thanks @yjernite - curious, what are the pros and cons of both approaches? When should one choose to use trigonometric functions vs applying an nn.Embedding on an ordinal index?

1 Like