Chapter 7 questions

Course
27

In the question answering section, I think there is a bug in this line:

if offset[context_start][0] > end_char or offset[context_end][1] < start_char:
    start_positions.append(0)
    end_positions.append(0)

It should be:

if offset[context_start][0] > start_char or offset[context_end][1] < end_char:
    start_positions.append(0)
    end_positions.append(0)

Am I correct? This is because earlier in the section, it’s written that:

“We will also set those labels (0, 0) in the unfortunate case where the answer has been truncated so that we only have the start (or end) of it.”

The following diagram explains this:

3500×1894 312 KB

Context 1 fully contains the answer. Context 2 STARTS AFTER the answer STARTS. Context 3 ENDS BEFORE the answer ENDS.