This is about the draft PR,
main ā ppbrown:sdxl-fix
opened 09:07PM - 25 May 25 UTC
# What does this PR do?
This makes the "optional" text modules in StableDiffuā¦ sionXLPipeline actually function as optional, instead of mandatory.
(There was already code present that suggests you can optionally skip modules: unfortunately, the code does not actually work that way, so this fixes the unfiled bug)
The patch can be verified by running the code mentioned in the target model in the README.md at
https://huggingface.co/opendiffusionai/sdxlone
## Before submitting
- [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
- [x ] Did you read the [contributor guideline](https://github.com/huggingface/diffusers/blob/main/CONTRIBUTING.md)?
- [ x] Did you read our [philosophy doc](https://github.com/huggingface/diffusers/blob/main/PHILOSOPHY.md) (important for complex PRs)?
- [ ] Was this discussed/approved via a GitHub issue or the [forum](https://discuss.huggingface.co/c/discussion-related-to-httpsgithubcomhuggingfacediffusers/63)? Please add a link to it if that's the case.
- [ ] Did you make sure to update the documentation with your changes? Here are the
[documentation guidelines](https://github.com/huggingface/diffusers/tree/main/docs), and
[here are tips on formatting docstrings](https://github.com/huggingface/diffusers/tree/main/docs#writing-source-documentation).
- [ ] Did you write any new necessary tests?
## Who can review?
Core library:
- Pipelines and pipeline callbacks: @yiyixuxu and @asomoza
I was planning to discuss it in discord, but the bot wont let me see the channels, even though it says I am already āRegisteredā for it.
Cut-n-pasting the PR description:
This makes the āoptionalā text modules in StableDiffusionXLPipeline actually function as optional, instead of mandatory.
The patch can be verified by running the code mentioned in the target model in the README.md atopendiffusionai/sdxlone Ā· Hugging Face
1 Like
There are ways to discuss this here actually, but I think it would definitely be better to discuss it on Discordā¦lunarflu.
Hey All! This thread is super old (4 years!) so will be closing it to minimize confusion (some outdated info) and help make joining discord even smoother.
The instructions for how to join have been updated in the discordās #how-to-access-discord channel, and for any questions or issues, feel free to DM me directly on discord @lunarflu !
okay thanks.Discord about it.
1 Like
